Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ansible role for Alloy #169

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Add ansible role for Alloy #169

merged 9 commits into from
Apr 10, 2024

Conversation

ishanjainn
Copy link
Member

No description provided.

@v-zhuravlev v-zhuravlev self-requested a review March 27, 2024 20:56
v-zhuravlev
v-zhuravlev approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@v-zhuravlev v-zhuravlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

gardar
gardar requested changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add molecule tests

@ishanjainn ishanjainn changed the title Add ansible role for Agent Flow Add ansible role for Alloy Apr 10, 2024
@ishanjainn ishanjainn mentioned this pull request Apr 10, 2024
Closed
@ishanjainn
Copy link
Member Author

Please add molecule tests

Hey @gardar I have a seperate PR coming for this and the Otel Collector role

@ishanjainn ishanjainn merged commit 6a232c4 into main Apr 10, 2024
9 checks passed
@ishanjainn ishanjainn deleted the agent-flow branch April 10, 2024 09:38
@gardar
Copy link
Collaborator

gardar commented Apr 10, 2024

IMHO the molecule tests should be included right from the start, it really helps with the development 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar requested changes

@v-zhuravlev v-zhuravlev v-zhuravlev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishanjainn @gardar @v-zhuravlev